chore(lint): allow uppercase abbreviations in commit subjects#69
Merged
Conversation
2a1b8bb to
7d4ec4b
Compare
- Disable subject-case rule to allow PR, API, CLI, URL, etc. - Remove duplicate commitlint.config.js (keep .commitlintrc.yml)
7d4ec4b to
63420bd
Compare
Contributor
Test Coverage Report - linux-amd64Total Coverage: Coverage by Package📊 Full HTML coverage report available in workflow artifacts |
Contributor
Test Coverage Report - macos-arm64Total Coverage: Coverage by Package📊 Full HTML coverage report available in workflow artifacts |
Contributor
Test Coverage Report - macos-amd64Total Coverage: Coverage by Package📊 Full HTML coverage report available in workflow artifacts |
Contributor
Test Coverage Report - windows-arm64Total Coverage: Coverage by Package📊 Full HTML coverage report available in workflow artifacts |
Contributor
Test Coverage Report - windows-amd64Total Coverage: Coverage by Package📊 Full HTML coverage report available in workflow artifacts |
Contributor
Author
|
/skip-changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subject-caserule to allow uppercase abbreviations like PR, API, CLI, URL, etc. in commit message subjectscommitlint.config.js(keep.commitlintrc.ymlas the single source of truth)Why
Commitlint's
subject-case: lower-caserule doesn't support ignoring common abbreviations. Since we use squash merges, PR titles become commit messages, and it's natural to write "remove PR comments" rather than "remove pr comments".Test plan
chore(ci): remove PR coverage commentspasses linting